Remove pattern matching based ATen evaluation for matmul#2268
Merged
Remove pattern matching based ATen evaluation for matmul#2268
Conversation
Collaborator
Author
|
!build |
jacobhinkle
approved these changes
May 20, 2024
| at::Tensor t0 = at::randn({M, K}, options); | ||
| at::Tensor t1 = at::randn({K, N}, options); | ||
| at::Tensor aten_output = matmul(t0.to(at::kDouble), t1.to(at::kDouble)); | ||
| at::Tensor aten_output = at::matmul(t0.to(at::kDouble), t1.to(at::kDouble)); |
Collaborator
There was a problem hiding this comment.
How is this working currently? There's no using namespace at; anywhere that I can see, and those are definitely at::Tensors.
Collaborator
Author
There was a problem hiding this comment.
It calls ATen matmul:
Thread 1 "nvfuser_tests" hit Breakpoint 2, at::matmul (self=..., other=...) at /usr/local/lib/python3.10/dist-packages/torch/include/ATen/ops/matmul.h:26
26 inline at::Tensor matmul(const at::Tensor & self, const at::Tensor & other) {
return at::_ops::matmul::call(self, other);
I wasn't aware it could be used without the namespace either. I changed it to remove any confusion with our matmul API although the input types will distinguish the two.
Priya2698
added a commit
that referenced
this pull request
May 21, 2024
We are removing pattern matching based evaluation since we are now using new IR nodes `MatmulOp` / `LinearOp` (Issue #2149). Removing pattern matching, and setting the disable option to clean the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are removing pattern matching based evaluation since we are now using new IR nodes
MatmulOp/LinearOp(Issue #2149). Removing pattern matching, and setting the disable option to clean the codebase.