Do not assume mul-sum pattern inputs are TensorView#2293
Merged
jacobhinkle merged 1 commit intomainfrom May 23, 2024
Merged
Conversation
This was a change I made to handle casts that wound up breaking some tests and benchmarks in #2272, leading to dynamic cast errors or segfaults. The solution is to test the type of the left and right hand sides before processing the pattern matching.
Collaborator
Author
|
!build |
Collaborator
Author
|
Multidevice tests are failing. The fusion looks like this Fuser/tests/cpp/test_multidevice_matmul.cpp Lines 91 to 108 in b85457e This creates an outer M dimension that is parallelized as DIDx. We should ignore such dimensions in pattern matching. |
zasdfgbnm
approved these changes
May 23, 2024
Collaborator
Author
|
Merging for now to mostly unblock CI then I will address the multidevice problem in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a change I made to handle casts that wound up breaking some tests and benchmarks in #2272, leading to dynamic cast errors or segfaults. The solution is to test the type of the left and right hand sides before processing the pattern matching.