[WIP DO NOT REVIEW] "Fold" operations to generalize Reductions#2307
Closed
jacobhinkle wants to merge 22 commits intomainfrom
Closed
[WIP DO NOT REVIEW] "Fold" operations to generalize Reductions#2307jacobhinkle wants to merge 22 commits intomainfrom
jacobhinkle wants to merge 22 commits intomainfrom
Conversation
It compiles! But is incorrect due to absolutely no codegen yet
T3 is still allocated too high (should be inlined with the other intermediates, and of course I'm not yet codegening the begin and end fold ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an experiment in generalizing
ReductionOpto handle a wider class of operations than those inBinaryOpType. The approach can be summarized as:IterType::Foldwhich represents dimensions that are "being reduced". These IterDomains must always be inlined with one another. The term "fold" was chosen to not conflict with the existing "reduction" terminology.IterType::Reductiondimensions.kir::Assignnodes which allow us to reassign a variable. This lets us update accumulation tensors inside a loop, for example.The goals of this design are:
scanin this setting, do so but only as a secondary consideration. The current implementation seeks to do this by allowing both scan and reduction outputs when finalizing a fold group.