Multidevice Executor add accessor to fusion executor caches#2421
Merged
cowanmeg merged 2 commits intoNVIDIA:mainfrom Jun 15, 2024
Merged
Multidevice Executor add accessor to fusion executor caches#2421cowanmeg merged 2 commits intoNVIDIA:mainfrom
cowanmeg merged 2 commits intoNVIDIA:mainfrom
Conversation
Collaborator
Author
|
!build |
wujingyue
reviewed
Jun 14, 2024
samnordmann
reviewed
Jun 14, 2024
Collaborator
Author
Yup relevant question. I think the only practical use case is for simple tests like these matmul tests where we have a linear sequence of computation so we know the order. The background for this PR is for matmul with ATen execution we want to check that the executor actually goes through ATen (#2386 (comment)) but to do that we need to access the FusionExecutorCache. |
wujingyue
approved these changes
Jun 14, 2024
Collaborator
|
Thanks for this PR -- I added these checks to the multidevice matmul tests! |
protonu
pushed a commit
that referenced
this pull request
Jun 24, 2024
Add `MultiDeviceExecutor::getFusionExecutorCaches` which returns a vector of pointers to the multidevice executor's fusion executor caches. Note, Also renames the field `workspace` to `workspace_` to match naming conventions. cc @Priya2698 for #2386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
MultiDeviceExecutor::getFusionExecutorCacheswhich returns a vector of pointers to the multidevice executor's fusion executor caches.Note, Also renames the field
workspacetoworkspace_to match naming conventions.cc @Priya2698 for #2386