Skip to content

Predication of non-divisible splits#2691

Merged
naoyam merged 10 commits intomainfrom
idmodel_indexing_non_divisible_split_predicate
Jul 27, 2024
Merged

Predication of non-divisible splits#2691
naoyam merged 10 commits intomainfrom
idmodel_indexing_non_divisible_split_predicate

Conversation

@naoyam
Copy link
Collaborator

@naoyam naoyam commented Jul 26, 2024

(Stacked on #2677)

Basically just porting what's already done with the current predication

@naoyam naoyam added the idmodel label Jul 26, 2024
@naoyam naoyam requested a review from jacobhinkle July 26, 2024 05:08
@naoyam
Copy link
Collaborator Author

naoyam commented Jul 26, 2024

!build

@naoyam
Copy link
Collaborator Author

naoyam commented Jul 26, 2024

Pinging @jacobhinkle

Copy link
Collaborator

@jacobhinkle jacobhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from idmodel_indexing_circular_buffer_predicate to main July 27, 2024 01:21
@naoyam naoyam merged commit 0e27969 into main Jul 27, 2024
@naoyam naoyam deleted the idmodel_indexing_non_divisible_split_predicate branch July 27, 2024 08:05
naoyam added a commit that referenced this pull request Jul 31, 2024
This is a bug fix for #2691, which isn't sufficient when broadcast
tensors are involved.

---------

Co-authored-by: Jacob Hinkle <1454944+jacobhinkle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants