Skip to content

Fix fp8 initialization type error#3246

Merged
jjsjann123 merged 2 commits intomainfrom
fp8_init_fix
Oct 22, 2024
Merged

Fix fp8 initialization type error#3246
jjsjann123 merged 2 commits intomainfrom
fp8_init_fix

Conversation

@naoyam
Copy link
Collaborator

@naoyam naoyam commented Oct 21, 2024

__e4m3 t = 0LL;

fails as there's no overload for long long.

We could work around this by generating "0" instead of "0LL". I don't see any difference in generated PTX.

Closes #3245

naoyam and others added 2 commits October 21, 2024 12:08
__e4m3 t = 0LL;

fails as there's no overload for long long.

We could work around this by generating "0" instead of "0LL". I don't
see any difference in generated PTX.
@naoyam
Copy link
Collaborator Author

naoyam commented Oct 21, 2024

!build

@naoyam naoyam requested a review from jjsjann123 October 22, 2024 02:23
@jjsjann123 jjsjann123 merged commit 65766e2 into main Oct 22, 2024
@jjsjann123 jjsjann123 deleted the fp8_init_fix branch October 22, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FP8 initialization type error

2 participants