Conversation
Collaborator
Author
|
!test |
Collaborator
|
!test --diff |
naoyam
reviewed
Dec 20, 2024
Collaborator
naoyam
left a comment
naoyam
left a comment
There was a problem hiding this comment.
Looks good, but just in case started the diff check
Collaborator
Author
|
!test --diff |
Collaborator
Author
|
@naoyam diff seems good: https://dl.gitlab-master-pages.nvidia.com/pytorch/fuser-gh-mirror//nvfuser_github_ci/codegen_diff_p22279271_j132723375_1736381273526255379_codediff_e057a9ba_636a399f_custom_command_20250108_152230.html The diff is due to the test change by this PR. |
zasdfgbnm
approved these changes
Jan 9, 2025
wujingyue
added a commit
that referenced
this pull request
Jan 14, 2025
naoyam
pushed a commit
that referenced
this pull request
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3479