Support scheduling transforms of size-0 IterDomains#367
Merged
jacobhinkle merged 5 commits intomainfrom May 18, 2023
Merged
Conversation
Kept the old one which exercises the pointwise scheduler too
Collaborator
Author
|
@jjsjann123 these checks were introduced in this pytorch/pytorch@6ab2a6f. It seems safe to me to remove it but I wanted to check with you first. If there are some other concerns around size-0, I'd be happy to add new test cases for those. |
jjsjann123
approved these changes
May 18, 2023
Collaborator
jjsjann123
left a comment
jjsjann123
left a comment
There was a problem hiding this comment.
I'm pretty sure this was just there to avoid some segfault from the old codegen time. Sorry for the confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366. Removes checks that extents are non-zero when performing splits and merges. Note that this is only relevant for scheduling currently, since even for dynamic reshapes, their concretizations are performed with static sizes, where extent checks happen.