Merged
Conversation
Currently only has one parameter
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
…r_update_heuristic
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
…r_update_heuristic
Collaborator
Author
|
!test |
jjsjann123
reviewed
Jan 13, 2025
| const int64_t bdimx = 128; | ||
|
|
||
| const auto& [largest_output, max_num_elms] = | ||
| getLargestTensor(fusion->outputs(), runtime_info); |
Collaborator
There was a problem hiding this comment.
Looks like we are not using largest_output. Is there another use of the function getLargestTensor where we need a pointer to the tensor?
Collaborator
Author
There was a problem hiding this comment.
It will be used in follow-up PRs
Collaborator
Author
|
!build |
jjsjann123
approved these changes
Jan 14, 2025
naoyam
added a commit
that referenced
this pull request
Jan 14, 2025
Currently only has one parameter. Also added some minor tweaks. - Previously gridDim.x was static, which is now symbolic. - Rejects transpose-like patterns for now as they would need scheduling like what the transpose does.
naoyam
added a commit
that referenced
this pull request
Jan 15, 2025
Depends on #3674, #3675, #3679 Reorder tensors to align with the largest input. This should improve memory accesses by minimizing strides. Store throughputs may be lowered, but it should generally be more important to optimize load accesses. I do not have actual performance results by this change. I just remember this was effective in some cases while manually trying out different optimization strategies. We may eventually need to enable or disable this reordering by some heuristic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only has one parameter. Also added some minor tweaks.