Updated generated filenames in run_command.sh#3805
Conversation
In #3788, the filename pattern `__tmp_kernel*.cu` was updated to `__tmp_*.cu` in `compare_codegen.sh`. That fix was incomplete, because `run_command.sh` also needs to move the generated files. This fix implements that change. I think this should finally fix codediff.
|
!test --diff |
|
Review updated until commit 15135e8 Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
I think it's ok to update the file name pattern matching for copy/paste/cleanup. We need to make sure the diff compare script is able to handle the broader name patterns.
E.g.
Fuser/tools/codediff/codediff.py
Lines 606 to 608 in b276c63
iiuc, the
.ptx file name without extension is expected to be the same as .cu file. Is this certain now, i.e. not having one __tmp_kernel (.cu) and one __tmp_nvfuser (.ptx, or vice versa), etc?
This should have been fixed by #3788 |
|
!test --diff |
|
Codediff is now working following some changes to internal tools. |
In #3788, the filename pattern
__tmp_kernel*.cuwas updated to__tmp_*.cuincompare_codegen.sh. That fix was incomplete, becauserun_command.shalso needs to move the generated files. This fix implements that change. I think this should finally fix codediff.