Conversation
zasdfgbnm
commented
May 23, 2023
| return vectorize_size; | ||
| } | ||
|
|
||
| size_t getExpandedVectorization( |
Collaborator
Author
There was a problem hiding this comment.
A big portion of getVectorizationFactor has been removed, so I just cut-paste the function body of this function into getVectorizationFactor and remove this function.
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
zasdfgbnm
commented
May 25, 2023
Collaborator
Author
|
!build |
naoyam
approved these changes
May 26, 2023
Collaborator
naoyam
left a comment
There was a problem hiding this comment.
The changes make sense to me. Have you found any change in actual vectorization?
Collaborator
Author
No, I didn't find any. But I didn't check programmatically. I just used my eye to inspect the output of and didn't find any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, vectorization analysis is done by first calling
getInnerDimVectorizableWidthto compute teh vectorization factor of the innermost dimension, then expand that to contiguous merge ofgetMaxVectorizableWidth. However, these two functions are very similar, almost a copy-paste of each other. Therefore, it makes no sense to usegetInnerDimVectorizableWidththengetMaxVectorizableWidth, we should removegetInnerDimVectorizableWidthand go directly togetMaxVectorizableWidth.This PR removes
getInnerDimVectorizableWidth, anded a boolean optioncontig_mergetogetMaxVectorizableWidthto reproduce the behavior ofgetInnerDimVectorizableWidth. Thecontig_merge=falseis only used in the transpose scheduler, where the which dimensions are contiguously merge to which ID is more complicated and is not considered in heuristics.Unfortunately, because the variable name change, I can not diff the kernel to check if they match exactly or not, but I do briefly skimmed through the diff by eye, and I don't find any change in the vectorization factor.
The V100 failure is OOM.