Skip to content

Disable LinearHostIrTest.HostIrLinearOut#3996

Closed
wujingyue wants to merge 3 commits intomainfrom
wjy/flake
Closed

Disable LinearHostIrTest.HostIrLinearOut#3996
wujingyue wants to merge 3 commits intomainfrom
wjy/flake

Conversation

@wujingyue
Copy link
Collaborator

No description provided.

@wujingyue
Copy link
Collaborator Author

!test

@github-actions
Copy link

github-actions bot commented Feb 28, 2025

Review updated until commit d71a174

Description

  • Disabled flaky test HostIrLinearOut

  • Added comments with links to issues


Changes walkthrough 📝

Relevant files
Bug fix
test_host_irs.cpp
Disabled flaky test and added comments                                     

tests/cpp/test_host_irs.cpp

  • Disabled HostIrLinearOut test
  • Added comments with links to issues
  • +3/-1     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Flaky Test

    The test HostIrLinearOut has been disabled due to flakiness. It is important to investigate the root cause of the flakiness and consider using at::randint and testValidate as suggested in the comment.

    // Disabled for being flaky (http://nv/ezW and http://nv/ez-). Consider
    // at::randint and testValidate.
    TEST_F(LinearHostIrTest, DISABLED_HostIrLinearOut) {

    @naoyam naoyam mentioned this pull request Mar 2, 2025
    @wujingyue wujingyue closed this Mar 3, 2025
    @wujingyue
    Copy link
    Collaborator Author

    Fixed by #4001

    @wujingyue wujingyue deleted the wjy/flake branch March 3, 2025 23:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant