Enable TensorIndexer with the transpose tests#4246
Merged
Conversation
Collaborator
Author
|
!test --diff |
|
Review updated until commit b28d962 Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
35ad7f5 to
c4c3eed
Compare
Collaborator
Author
|
!test --diff |
Collaborator
Author
|
!test --diff |
25e0de3 to
efb63a5
Compare
Collaborator
Author
|
!test --diff |
b28d962 to
70defd4
Compare
Collaborator
Author
|
!test --diff |
Contributor
Greptile Summary
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as TransposeTest
participant Setup as SetUp()
participant Options as EnableOptionsGuard
participant IdModel as TensorIndexer
participant Tests as Test Cases
Test->>Setup: "Initialize test fixture"
Setup->>Options: "set(EnableOption::IdModel, {\"all\"})"
Options->>IdModel: "Enable TensorIndexer for all operations"
Setup->>Tests: "Run transpose tests"
Tests->>IdModel: "Generate indices using TensorIndexer"
IdModel->>Tests: "Return conservative predicates"
|
Contributor
There was a problem hiding this comment.
1 file reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling TensorIndexer for the transpose tests. Diff check revealed some mismatches, but I believe they are benign. As far as I can see, all of them are caused by some slight difference for issue #681. TensorIndexer's workaround is simpler but not as precise as the legacy indexer, as indicated in #2689.
For example, there is an index for a predicate of
TransposeTest.FusionScheduleTransposeSimple:The above is generated by the legacy indexer. With TensorIndexer, it's generated as:
The difference is
threadIdx.x 4 % 32vs.0. Note that this is a predicate for the condition at the start position, i.e., they are predicated with>= 0, and as such the index of TensorIndexer is more conservative, so the legacy indexer may have a higher chance of using the fast path created by the unswitch predicate. However, in practice, both predicates should be always true, so it shouldn't matter. I don't see any actual difference with stop predicates.