Skip to content

Disable two flaky tests to keep CI green#4283

Merged
wujingyue merged 3 commits intomainfrom
wjy/disable
Apr 19, 2025
Merged

Disable two flaky tests to keep CI green#4283
wujingyue merged 3 commits intomainfrom
wjy/disable

Conversation

@wujingyue
Copy link
Collaborator

No description provided.

@wujingyue
Copy link
Collaborator Author

!test

@wujingyue wujingyue requested a review from naoyam April 19, 2025 03:30
@github-actions
Copy link

github-actions bot commented Apr 19, 2025

Review updated until commit d5a9259

Description

  • Disabled two flaky tests to stabilize CI

  • Updated test names with DISABLED_ prefix


Changes walkthrough 📝

Relevant files
Tests
test_multidevice_communications.cpp
Disable CudaComm test                                                                       

tests/cpp/test_multidevice_communications.cpp

  • Disabled CudaComm test by renaming it to DISABLED_CudaComm
+1/-1     
test_multidevice_host_ir.cpp
Disable ShareIpcMemHandles test                                                   

tests/cpp/test_multidevice_host_ir.cpp

  • Disabled ShareIpcMemHandles test by renaming it to
    DISABLED_ShareIpcMemHandles
  • +1/-1     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Flaky Test

    The test CudaComm has been disabled due to flakiness. It should be investigated to understand the root cause of the flakiness and addressed to ensure the test suite remains robust.

    TEST_F(P2PCommunicationTest, DISABLED_CudaComm) {
    Flaky Test

    The test ShareIpcMemHandles has been disabled due to flakiness. It should be investigated to understand the root cause of the flakiness and addressed to ensure the test suite remains robust.

    TEST_F(MultiDeviceTest, DISABLED_ShareIpcMemHandles) {

    @wujingyue
    Copy link
    Collaborator Author

    !test

    @wujingyue
    Copy link
    Collaborator Author

    !test

    @wujingyue wujingyue merged commit bb5b38c into main Apr 19, 2025
    47 of 48 checks passed
    @wujingyue wujingyue deleted the wjy/disable branch April 19, 2025 04:39
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants