Skip to content

Change build directory for clang-tidy in lintrunner#4309

Merged
rdspring1 merged 1 commit intomainfrom
fix_clang_tidy
Apr 24, 2025
Merged

Change build directory for clang-tidy in lintrunner#4309
rdspring1 merged 1 commit intomainfrom
fix_clang_tidy

Conversation

@rdspring1
Copy link
Collaborator

This PR fixes the clang-tidy lintrunner. The build_dir argument needs to change from ./build to ./python/build.

@rdspring1
Copy link
Collaborator Author

!build

@github-actions
Copy link

Description

  • Update clang-tidy build directory in lintrunner

Changes walkthrough 📝

Relevant files
Configuration changes
.lintrunner.toml
Update clang-tidy build directory                                               

.lintrunner.toml

  • Change build_dir from ./build to ./python/build in clang-tidy command
  • +1/-1     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Configuration Change

    The change in the build_dir argument from ./build to ./python/build should be validated to ensure it does not break the existing workflow or introduce any issues with the clang-tidy linter.

    '--build_dir=./python/build',

    @rdspring1 rdspring1 merged commit 95c9bde into main Apr 24, 2025
    14 of 15 checks passed
    @rdspring1 rdspring1 deleted the fix_clang_tidy branch April 24, 2025 17:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants