Merged
Conversation
This reverts commit 85f9894.
nsarka
force-pushed
the
nsarka/revert-revert-deallocate
branch
from
92c0df6 to
c1dc3a7
Compare
Member
Author
|
!test |
nsarka
commented
Apr 29, 2025
| at::cuda::clearCublasWorkspaces(); | ||
| nvfuser::releaseZeroedMemory(); | ||
| ASSERT_EQ(memoryAllocated(device_index), 0) | ||
| << "Previous tests leaked memory."; |
Member
Author
There was a problem hiding this comment.
This is the CI fix suggested by Jingyue. I'm waiting for the !test command to finish to see if it's enough.
wujingyue
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4303 with CI fix