Conversation
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
naoyam
reviewed
Jul 24, 2025
| namespace nvfuser { | ||
|
|
||
| bool MatmulScheduler::canScheduleCompileTime(Fusion* fusion) { | ||
| for (auto tv : fusion->allTvs()) { |
Collaborator
There was a problem hiding this comment.
I'm fine with this, but we could also do this uniformly at https://github.com/NVIDIA/Fuser/blob/main/csrc/scheduler/registry.cpp#L25.
Collaborator
Author
There was a problem hiding this comment.
I would suggest doing it in each scheduler, this way, in the future, we can just remove this per scheduler when we incrementally enable support for fp4.
naoyam
reviewed
Jul 24, 2025
| TensorDomain::getContiguityFilledWith(logical_domain, true)), | ||
| x->getDataType().value()); | ||
| IrBuilder::create<ViewOp>(x, out_tv); | ||
| IrBuilder::create<ViewOp>(out_tv, x); |
Collaborator
There was a problem hiding this comment.
Ha, so this has been wrong, right? Thanks for fixing it.
Collaborator
Author
There was a problem hiding this comment.
You are right. It's a bug. It was not discovered until we started running the fusion definition.
wujingyue
added a commit
that referenced
this pull request
Jul 26, 2025
This reverts commit a70e0f5. It broke ``` _bn && pytest tests/python/opinfo/test_legacy_ops.py -k test_correctness_abs_float64 -s ```
wujingyue
added a commit
that referenced
this pull request
Jul 26, 2025
nsarka
pushed a commit
to nsarka/Fuser
that referenced
this pull request
Jul 28, 2025
nsarka
pushed a commit
to nsarka/Fuser
that referenced
this pull request
Jul 28, 2025
zasdfgbnm
added a commit
that referenced
this pull request
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4748