fp4 packed dtype support on direct python API#5380
Conversation
|
Review updated until commit 5a84246 Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
cherry-picked from already stamped changes by @rdspring1 from #5230 |
|
!test |
|
!test |
|
!test |
|
!test |
|
!test |
Cherry-picked from #5230 * packed fp4 dtype needs to be supported by python API in order to support framework integration. FusionDefinition is not expecting to have packed dtype. But since that's the only fp4 dtype supported by framework, our integration would still need to support it. This PR adds a quick translation at `FusionDefinition.define_tensor` to translate packed dtype into unpacked dtype to keep the WAR transparent to integration/user.
Cherry-picked from #5230
FusionDefinition is not expecting to have packed dtype. But since that's the only fp4 dtype supported by framework, our integration would still need to support it.
This PR adds a quick translation at
FusionDefinition.define_tensorto translate packed dtype into unpacked dtype to keep the WAR transparent to integration/user.