Avoid segfault in segmentation with dangling unary ops#586
Merged
jacobhinkle merged 7 commits intomainfrom Jul 14, 2023
Merged
Conversation
naoyam
approved these changes
Jul 13, 2023
Collaborator
naoyam
left a comment
naoyam
left a comment
There was a problem hiding this comment.
LGTM. The reason this only happens with a scalar and not with a tensor is that we delete uses that do not lead to fusion outputs. So, if a unary-op sequence from a tensor input does not lead to an output, the uses of the fusion input should be empty, so we shouldn't add anything to to_visit.
Collaborator
|
Nice catch and thanks for fixing! |
Co-authored-by: Naoya Maruyama <naoyam@users.noreply.github.com>
Co-authored-by: Naoya Maruyama <naoyam@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #585