Use expanded extent for empty check in RemoveEmptyPass#604
Merged
jacobhinkle merged 6 commits intomainfrom Jul 19, 2023
Merged
Conversation
Collaborator
Author
|
!build |
Collaborator
Author
|
Test failures are unrelated: 1133 on A100 and torchscript |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When replacing empty tensors with
fullinRemoveEmptyPass(#543), we use theextentto determine the output shape. This is a problem if that tensor was the output of anexpandcall, because then even a tensor that is not empty might appear to be so if an expanded extent is zero. This change addresses this issue by usinggetMaybeExpandedExtentinRemoveEmptyPassand during concretization for finding empty tensors.Fixes #603