Skip to content

Ignore trivial loops in memory aliasing pass #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobhinkle merged 4 commits into from
Aug 28, 2023
Merged

Ignore trivial loops in memory aliasing pass #766

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c06a18
Ignore trivial loops in memory aliasing pass
jacobhinkle Aug 22, 2023
e5cc2b7
Merge branch 'main' into alias_pass_ignore_trivial_loops
jacobhinkle Aug 23, 2023
a1ea6be
Merge branch 'main' into alias_pass_ignore_trivial_loops
jacobhinkle Aug 25, 2023
f031d8c
Merge remote-tracking branch 'origin/main' into alias_pass_ignore_tri…
jacobhinkle Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions csrc/device_lower/pass/alias_memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,15 +769,23 @@ class AllocationInfoMap : private kir::IrVisitor {

void handle(kir::ForLoop* for_loop) final {
auto loop_info = scope_map_.getLoopScopeInfo(for_loop);
current_stack_.push_back(loop_info);
if (!for_loop->isTrivial()) {
// Parallelized loops do not result in for loops in the CUDA kernel, so
// they should not affect liveness analysis. This means that
// current_stack_ will differ from kir::IrVisitor::for_loops_, which will
// actually hold all ForLoops regardless of parallelization.
current_stack_.push_back(loop_info);
}
if (debug_printer_) {
debug_printer_->pushScope();
}
kir::IrVisitor::handle(for_loop);
if (debug_printer_) {
debug_printer_->popScope();
}
current_stack_.pop_back();
if (!for_loop->isTrivial()) {
current_stack_.pop_back();
}
}

void handle(kir::IfThenElse* ite) final {
Expand Down