Rewrite ParallelDimensionMap with expr simplifier#86
Merged
Conversation
zasdfgbnm
commented
Mar 28, 2023
| } | ||
|
|
||
| const auto tidx_pt = ParallelType::TIDx; | ||
| auto warp_size = at::cuda::warp_size(); |
Collaborator
Author
There was a problem hiding this comment.
at::cuda::warp_size(); was added to support ROCm, which we no longer care anymore.
ParallelDimensionMap with expr simplifier
Collaborator
Author
|
!build |
This was referenced Mar 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am seeing trivial thread predicate in one matmul schedule #87, and that trivial thread predicate causes a 10% slowdown. So I start my work on removing that predicate. My first step is a rewrite of
ParallelDimensionMap. The new code is much shorter in lines of code, and should have better result (for example, inFusionParallelDimensionMap3_CUDA,blockDim.xbecomes20).This PR uses the following equation to calculate the extent of a parallel dim:
Future work:
parallel_index < parallel_dimin additional toFuser/csrc/expr_simplifier.cpp
Line 152 in 3e69f69
isExact(ptype), but also when the loop extent equalsparallel_dim.Fuser/csrc/executor.cpp
Line 660 in 548d5d2