Preserve symbolic reshape extents after concretization#912
Draft
jacobhinkle wants to merge 5 commits intomainfrom
Draft
Preserve symbolic reshape extents after concretization#912jacobhinkle wants to merge 5 commits intomainfrom
jacobhinkle wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #840.
This PR changes how concretization behaves with respect to dynamic
reshapeoperations. When we receive a dynamic reshape, we wind up with a symbolic fusion that looks something like this (DynamicTransform3_CUDA):Notice the
ceilDivexpressions that are propagated downstream of the concretizedreshape. After this PR, the above Fusion concretizes as:New missing scalars
This change is stacked on #840 since in some cases, we can lose track of these dynamic extent scalars. For example, in
DynamicTransformIssue418_CUDA, we have this symbolic Fusion and concretization:This is segmented at
T8_land the first segment looks likeThis fails to compile since
i5is not included as an input to this segment. In this case we need to inspect the output of theViewOpto find missing scalars.