Conversation
drzejan2
approved these changes
Mar 29, 2023
| // CTA tile: | ||
|
|
||
| // Swizzle block tiles: | ||
| c->swizzle(Swizzle2DType::ZShape, 0, 1, SwizzleMode::Loop); |
Contributor
There was a problem hiding this comment.
It looks like this is the only place where TensorView::swizzle function is currently used in production.
Do you think it should be kept, or should it be removed, along with tests for it? (test_gpu_tensorcore.cpp and test_gpu_swizzle.cpp). Perhaps there are use cases where it will be required, but nothing comes to my mind right away.
Other than this, PR looks good to me.
Collaborator
Author
There was a problem hiding this comment.
TensorView::swizzle should also be applied to the shared memory buffer to remove bank conflict. It is now in main branch now, but #41 will add it.
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
z-shape swizzle was not used in tracking-matmul, and now we have a better swizzle implemented in #90