rename all nvfuser benchmarks start with NvFuserScheduler_#930
Merged
rename all nvfuser benchmarks start with NvFuserScheduler_#930
Conversation
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
naoyam
approved these changes
Sep 25, 2023
Collaborator
naoyam
left a comment
naoyam
left a comment
There was a problem hiding this comment.
LGTM. Some of the benchmarks are not really about the scheduler. That's fine for now, but we should reconsider naming when we move the benchmarks to Python. CC: @Priya2698
| } | ||
|
|
||
| static void LayerNormBackward_ShapeInference( | ||
| static void NvFuserScheduler_LayerNormBackward_ShapeInference( |
Collaborator
There was a problem hiding this comment.
We should probably use a different name for this as it doesn't run the scheduler, but I think it's fine for now.
Collaborator
Author
|
!build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI is filtering nvfuser benchmark cases with
NvFuserScheduler_*, however the names of some nvfuser cases are not started withNvFuserScheduler_. This PR addsNvFuserScheduler_to these cases.