Skip to content

clean normalization_outer#931

Merged
liqiangxl merged 5 commits intomainfrom
llu/clean_outer_norm
Sep 26, 2023
Merged

clean normalization_outer#931
liqiangxl merged 5 commits intomainfrom
llu/clean_outer_norm

Conversation

@liqiangxl
Copy link
Collaborator

@liqiangxl liqiangxl commented Sep 22, 2023

similar to #923
(1) Transformed private static functions in the OuterPersistentKernelScheduler class into utility functions within an anonymous namespace.
(2) Removed checks/calculations that are unrelated to outer persistent scheduler.

@liqiangxl
Copy link
Collaborator Author

!build

@liqiangxl
Copy link
Collaborator Author

!build

@liqiangxl liqiangxl marked this pull request as ready for review September 23, 2023 16:48
@liqiangxl liqiangxl requested a review from naoyam September 23, 2023 16:50
@liqiangxl
Copy link
Collaborator Author

!build

1 similar comment
@liqiangxl
Copy link
Collaborator Author

!build

@liqiangxl
Copy link
Collaborator Author

!build

Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liqiangxl liqiangxl merged commit 5e2db6a into main Sep 26, 2023
@liqiangxl liqiangxl deleted the llu/clean_outer_norm branch September 26, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants