Skip to content

Isolate per-run Docker and CloudXR resources for ROS test#382

Open
sgrizan-nv wants to merge 1 commit intomainfrom
sgrizan/branch3
Open

Isolate per-run Docker and CloudXR resources for ROS test#382
sgrizan-nv wants to merge 1 commit intomainfrom
sgrizan/branch3

Conversation

@sgrizan-nv
Copy link
Copy Markdown
Collaborator

@sgrizan-nv sgrizan-nv commented Apr 10, 2026

This way concurrent self-hosted jobs won't interfere with each other

Summary by CodeRabbit

  • Chores
    • Enhanced build process isolation by implementing per-job resource tagging and temporary file management.
    • Improved build reliability through better cleanup procedures and runtime file organization.

@sgrizan-nv sgrizan-nv self-assigned this Apr 10, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 05c3e9c8-fe96-4298-8855-89939b4d5f2e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The GitHub Actions workflow file is refactored to improve job isolation and Docker image management. The changes implement per-job directory structures and image tagging: Docker images are tagged with run-specific identifiers (run ID, attempt, architecture, ROS distro), CloudXR runtime configuration is written to a temporary per-job docker-compose.override.yaml under ${RUN_ROOT} instead of modifying static files, the teleop container references the newly built per-job image tag, and cleanup removes the per-job temporary directory. The CXR_HOST_VOLUME_PATH is configured as a per-job path to isolate CloudXR runtime files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: isolating per-run Docker and CloudXR resources to prevent interference between concurrent jobs in the ROS test workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgrizan/branch3

Comment @coderabbitai help to get the list of available commands and usage tips.

This way concurrent self-hosted jobs won't interfere with each other
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants