Skip to content

ROS: Swap left and right EE in EE topic#385

Open
sgrizan-nv wants to merge 1 commit intomainfrom
sgrizan/branch2
Open

ROS: Swap left and right EE in EE topic#385
sgrizan-nv wants to merge 1 commit intomainfrom
sgrizan/branch2

Conversation

@sgrizan-nv
Copy link
Copy Markdown
Collaborator

@sgrizan-nv sgrizan-nv commented Apr 10, 2026

Summary by CodeRabbit

  • Documentation

    • Updated xr_teleop/ee_poses topic mapping documentation to reflect current hand-to-pose associations.
  • Bug Fixes

    • Corrected left and right hand end-effector pose ordering: poses[0] now represents the left hand and poses[1] represents the right hand.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5593357a-0ed8-4cbd-893f-0da3040dab44

📥 Commits

Reviewing files that changed from the base of the PR and between 6448028 and 89a0953.

📒 Files selected for processing (2)
  • examples/teleop_ros2/README.md
  • examples/teleop_ros2/python/teleop_ros2_node.py

📝 Walkthrough

Walkthrough

This pull request reverses the index-to-hand mapping for the xr_teleop/ee_poses topic from [right_ee, left_ee] to [left_ee, right_ee]. The README is updated to reflect this new documentation. The Python node implementation is modified in three methods to swap which controller/hand pose is appended at each index and to update wrist frame creation to use the new indices, while preserving the availability gating logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ROS: Swap left and right EE in EE topic' directly and specifically describes the main change: reversing the left/right ordering of end-effector poses in the xr_teleop/ee_poses topic across documentation and implementation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgrizan/branch2

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant