Skip to content

Comments

feat: Apply RoPE embedding with sequence offsets#2416

Open
sudhakarsingh27 wants to merge 6 commits intoNVIDIA:mainfrom
sudhakarsingh27:expose_start_positions_rope
Open

feat: Apply RoPE embedding with sequence offsets#2416
sudhakarsingh27 wants to merge 6 commits intoNVIDIA:mainfrom
sudhakarsingh27:expose_start_positions_rope

Conversation

@sudhakarsingh27
Copy link
Contributor

What does this PR do ?

Allows applying rope embedding with "offsets" to sequences in packed (thd) or batch (bshd/sbhd) formats. The offset per sequence can be supplied as an argument start_positions tensor.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
@sudhakarsingh27 sudhakarsingh27 requested review from a team as code owners November 26, 2025 23:23
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@deepakn94
Copy link
Contributor

/ok to test c3e83ad

Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
@sudhakarsingh27
Copy link
Contributor Author

/ok to test

@sudhakarsingh27
Copy link
Contributor Author

/ok to test f0461ab

@ericharper ericharper requested a review from BoxiangW November 26, 2025 23:59
@sudhakarsingh27
Copy link
Contributor Author

/ok to test 58ba726

@sudhakarsingh27
Copy link
Contributor Author

/ok to test 76b60a8

@sudhakarsingh27
Copy link
Contributor Author

/ok to test bb95919

assert output.dtype == torch.float32
assert output.device.type == 'cuda'

@pytest.mark.internal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for TE >= 2.10? With something like

@pytest.mark.skipif(
    not is_te_min_version("2.10.0", check_equality=True),
    reason="Requires TransformerEngine >= 2.10.0",
)

@BoxiangW BoxiangW added complexity: low Expert Review Apply this label to indicate that your PR is ready for expert review. labels Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants