Refactor setup.py to use get_pybind_include#2611
Refactor setup.py to use get_pybind_include#2611sakgoyal wants to merge 2 commits intoNVIDIA:devfrom
Conversation
|
@ko3n1g Sorry for the ping. Just wanted to know when I should expect this to get merged |
|
@Skylion007 do you know how I can get ko3n1g to review this? |
|
/ok to test 935a5bb |
|
Hey @sakgoyal , thanks for your contribution! It looks like CI is failing, I will try to take a look. However as vacations are upcoming it might get delayed a bit. |
|
These failures don't seem to be from my PR. seems that something else went wrong that caused this to fail. Also, should I update this PR (rebase / merge to HEAD) or leave it as it is? Not sure what the policy is for PRs |
|
These workflows are passing in the target branch: https://github.com/NVIDIA/Megatron-LM/actions/workflows/build-test-publish-wheel.yml?query=branch%3Adev So we need do need to take a closer look.. |
|
/ok to test e9641e9 |
|
Thank you for your contribution! NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process. Thank you for your understanding. |
|
should I do an update with rebase through github for this PR? or should I leave it alone? I'd like to run CI again on this if possible. Im asking because I don't understand some of the CI errors about the whl not being valid as my changes should not be affecting that. |
What does this PR do ?
Try to fix bugs when installing on windows with uv. see #2609
Pre-checks
Core 0.8)