Skip to content

Comments

Refactor setup.py to use get_pybind_include#2611

Open
sakgoyal wants to merge 2 commits intoNVIDIA:devfrom
sakgoyal:patch-1
Open

Refactor setup.py to use get_pybind_include#2611
sakgoyal wants to merge 2 commits intoNVIDIA:devfrom
sakgoyal:patch-1

Conversation

@sakgoyal
Copy link

@sakgoyal sakgoyal commented Dec 10, 2025

What does this PR do ?

Try to fix bugs when installing on windows with uv. see #2609

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

@sakgoyal sakgoyal requested review from a team as code owners December 10, 2025 04:46
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12 yaox12 requested review from a team and ko3n1g December 10, 2025 06:17
@yaox12 yaox12 added the Expert Review Apply this label to indicate that your PR is ready for expert review. label Dec 10, 2025
@sakgoyal
Copy link
Author

@ko3n1g Sorry for the ping. Just wanted to know when I should expect this to get merged

@sakgoyal
Copy link
Author

@Skylion007 do you know how I can get ko3n1g to review this?

@ko3n1g
Copy link
Contributor

ko3n1g commented Dec 20, 2025

/ok to test 935a5bb

@ko3n1g
Copy link
Contributor

ko3n1g commented Dec 20, 2025

Hey @sakgoyal , thanks for your contribution! It looks like CI is failing, I will try to take a look. However as vacations are upcoming it might get delayed a bit.

@sakgoyal
Copy link
Author

sakgoyal commented Dec 21, 2025

These failures don't seem to be from my PR. seems that something else went wrong that caused this to fail.

Also, should I update this PR (rebase / merge to HEAD) or leave it as it is? Not sure what the policy is for PRs

@ko3n1g
Copy link
Contributor

ko3n1g commented Dec 21, 2025

These workflows are passing in the target branch: https://github.com/NVIDIA/Megatron-LM/actions/workflows/build-test-publish-wheel.yml?query=branch%3Adev

So we need do need to take a closer look..

@ko3n1g
Copy link
Contributor

ko3n1g commented Dec 21, 2025

/ok to test e9641e9

@github-actions
Copy link
Contributor

Thank you for your contribution!

NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process.

Thank you for your understanding.

@sakgoyal
Copy link
Author

sakgoyal commented Jan 8, 2026

should I do an update with rebase through github for this PR? or should I leave it alone? I'd like to run CI again on this if possible.

Im asking because I don't understand some of the CI errors about the whl not being valid as my changes should not be affecting that.

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 11, 2026
@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants