[dev] feat(moe): Support packed sequence for gated delta net (GDN)#2644
Open
yuzhongw-nvidia wants to merge 5 commits intoNVIDIA:devfrom
Open
[dev] feat(moe): Support packed sequence for gated delta net (GDN)#2644yuzhongw-nvidia wants to merge 5 commits intoNVIDIA:devfrom
yuzhongw-nvidia wants to merge 5 commits intoNVIDIA:devfrom
Conversation
6 tasks
2575c6d to
4f8888d
Compare
4f8888d to
9ccf5a4
Compare
73d512d to
ae8806c
Compare
Contributor
Author
|
/ok to test ae8806c |
83a8607 to
545a2a5
Compare
Contributor
Author
|
/ok to test 545a2a5 |
545a2a5 to
befbcd2
Compare
44 tasks
Contributor
|
Also need to update this line https://github.com/yuzhongw-nvidia/Megatron-LM/blob/befbcd2a10b60deb4edbd0f758275b26a6df83c7/megatron/core/ssm/gated_delta_net.py#L741 to |
Contributor
Author
Thanks. Resolved. |
Signed-off-by: yuzhongw <yuzhongw@nvidia.com> Co-authored-by: kunlunl <kunlunl@nvidia.com>
58fdd22 to
e8ed23c
Compare
kunlunl
approved these changes
Jan 29, 2026
Contributor
|
/ok to test 80d2d1c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Support packed sequence for gated delta net (GDN).
PR for main: #2645
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.