Skip to content

Comments

[dev] feat(moe): Support packed sequence for gated delta net (GDN)#2644

Open
yuzhongw-nvidia wants to merge 5 commits intoNVIDIA:devfrom
yuzhongw-nvidia:gdn_thd
Open

[dev] feat(moe): Support packed sequence for gated delta net (GDN)#2644
yuzhongw-nvidia wants to merge 5 commits intoNVIDIA:devfrom
yuzhongw-nvidia:gdn_thd

Conversation

@yuzhongw-nvidia
Copy link
Contributor

@yuzhongw-nvidia yuzhongw-nvidia commented Dec 12, 2025

What does this PR do ?

Support packed sequence for gated delta net (GDN).

PR for main: #2645

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yuzhongw-nvidia yuzhongw-nvidia requested review from a team as code owners December 12, 2025 13:12
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia
Copy link
Contributor Author

/ok to test ae8806c

@yuzhongw-nvidia
Copy link
Contributor Author

/ok to test 545a2a5

@yaox12 yaox12 added the Expert Review Apply this label to indicate that your PR is ready for expert review. label Jan 23, 2026
@kunlunl
Copy link
Contributor

kunlunl commented Jan 28, 2026

@yuzhongw-nvidia
Copy link
Contributor Author

Also need to update this line https://github.com/yuzhongw-nvidia/Megatron-LM/blob/befbcd2a10b60deb4edbd0f758275b26a6df83c7/megatron/core/ssm/gated_delta_net.py#L741 to param = param[tuple(slices)]?

Thanks. Resolved.

@kunlunl
Copy link
Contributor

kunlunl commented Jan 29, 2026

/ok to test 80d2d1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants