Skip to content

Add Qwen3-VL support with Megatron-FSDP#2841

Merged
xuwchen merged 6 commits intoNVIDIA:mainfrom
xuwchen:qwen3_vl
Feb 12, 2026
Merged

Add Qwen3-VL support with Megatron-FSDP#2841
xuwchen merged 6 commits intoNVIDIA:mainfrom
xuwchen:qwen3_vl

Conversation

@xuwchen
Copy link
Contributor

@xuwchen xuwchen commented Jan 7, 2026

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @megatron-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @megatron-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@xuwchen xuwchen requested review from a team as code owners January 7, 2026 08:44
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 7, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot requested a review from Phlip79 January 7, 2026 08:44
@shjwudp shjwudp added Expert Review Apply this label to indicate that your PR is ready for expert review. module: megatron-fsdp labels Jan 26, 2026
self._log_parameter_groups()

# Sync parameter requires_grad with its parameter group.
self._sync_parameter_requires_grad_with_group()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the purpose of adding this function? As I understand it, group.requires_grad is derived from param.requires_grad.

@Phlip79 Phlip79 removed their request for review January 26, 2026 20:23
@Phlip79
Copy link
Member

Phlip79 commented Jan 26, 2026

@xuwchen please add a description to the PR.

@Phlip79 Phlip79 added the Final Review Apply this label to indicate that your PR is ready for final review. label Feb 11, 2026
@xuwchen
Copy link
Contributor Author

xuwchen commented Feb 12, 2026

/ok to test 7d99185

@Phlip79 Phlip79 requested review from a team, BoxiangW and shjwudp February 12, 2026 06:33
@xuwchen xuwchen added this pull request to the merge queue Feb 12, 2026
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21939946112

Merged via the queue into NVIDIA:main with commit 7df15bd Feb 12, 2026
48 of 52 checks passed
@xuwchen xuwchen deleted the qwen3_vl branch February 12, 2026 10:05
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review Apply this label to indicate that your PR is ready for expert review. Final Review Apply this label to indicate that your PR is ready for final review. module: megatron-fsdp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants