Skip to content

Ensure that last prefill chunk is handled correctly by Mamba models#2897

Merged
santhnm2 merged 22 commits intoNVIDIA:mainfrom
santhnm2:chunked_prefill_fix
Jan 22, 2026
Merged

Ensure that last prefill chunk is handled correctly by Mamba models#2897
santhnm2 merged 22 commits intoNVIDIA:mainfrom
santhnm2:chunked_prefill_fix

Conversation

@santhnm2
Copy link
Contributor

@santhnm2 santhnm2 commented Jan 10, 2026

What does this PR do ?

This PR fixes a scheduler bug for chunked prefill with Mamba models. The scheduler sets chunked_prefill_request_id to -1 for the last prefill chunk and then continues scheduling additional requests if it can. This PR instead terminates scheduling early for Mamba models on the last prefill chunk and also sets the has_explicit_chunked_prefill_req flag to True for any prefill chunk, including the last one. This ensures that Mamba models always go through the chunked prefill path when they need to. This PR also adds a functional test for Mamba chunked prefill and disables chunked prefill by default.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2 santhnm2 requested review from a team as code owners January 10, 2026 07:11
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 10, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@santhnm2
Copy link
Contributor Author

/ok to test 7a2ac67

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Contributor Author

/ok to test 0e96a3e

@santhnm2
Copy link
Contributor Author

/ok to test 242f17a

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Contributor Author

/ok to test e2d917a

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Contributor Author

/ok to test 454060e

@santhnm2 santhnm2 added this pull request to the merge queue Jan 21, 2026
Merged via the queue into NVIDIA:main with commit 096dbeb Jan 22, 2026
54 of 58 checks passed
@santhnm2 santhnm2 deleted the chunked_prefill_fix branch January 22, 2026 00:21
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants