Ensure that last prefill chunk is handled correctly by Mamba models#2897
Merged
santhnm2 merged 22 commits intoNVIDIA:mainfrom Jan 22, 2026
Merged
Ensure that last prefill chunk is handled correctly by Mamba models#2897santhnm2 merged 22 commits intoNVIDIA:mainfrom
santhnm2 merged 22 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Contributor
Author
|
/ok to test 7a2ac67 |
kvareddy
approved these changes
Jan 10, 2026
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Contributor
Author
|
/ok to test 0e96a3e |
Contributor
Author
|
/ok to test 242f17a |
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Contributor
Author
|
/ok to test e2d917a |
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Contributor
Author
|
/ok to test 454060e |
chtruong814
approved these changes
Jan 21, 2026
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
…VIDIA#2897) Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes a scheduler bug for chunked prefill with Mamba models. The scheduler sets
chunked_prefill_request_idto -1 for the last prefill chunk and then continues scheduling additional requests if it can. This PR instead terminates scheduling early for Mamba models on the last prefill chunk and also sets thehas_explicit_chunked_prefill_reqflag toTruefor any prefill chunk, including the last one. This ensures that Mamba models always go through the chunked prefill path when they need to. This PR also adds a functional test for Mamba chunked prefill and disables chunked prefill by default.Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.