Skip to content

Comments

Set token_dtype_code init value in GPTDatasetConfig to fix CI#2912

Merged
ko3n1g merged 4 commits intoNVIDIA:mainfrom
asolergi-nv:token_dtype_code_init
Jan 17, 2026
Merged

Set token_dtype_code init value in GPTDatasetConfig to fix CI#2912
ko3n1g merged 4 commits intoNVIDIA:mainfrom
asolergi-nv:token_dtype_code_init

Conversation

@asolergi-nv
Copy link
Contributor

@asolergi-nv asolergi-nv commented Jan 12, 2026

What does this PR do ?

NeMo CI was crashing in a mbridge test because the __post_init__ method was not being called correctly. This fix protects against this type of errors.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@asolergi-nv asolergi-nv requested review from a team as code owners January 12, 2026 21:49
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@asolergi-nv
Copy link
Contributor Author

/ok to test 94830c6

@Phlip79
Copy link
Member

Phlip79 commented Jan 14, 2026

Please update description.

@Phlip79 Phlip79 added Expert Review Apply this label to indicate that your PR is ready for expert review. complexity: low labels Jan 14, 2026
@asolergi-nv asolergi-nv added Final Review Apply this label to indicate that your PR is ready for final review. and removed Expert Review Apply this label to indicate that your PR is ready for expert review. labels Jan 15, 2026
@Phlip79 Phlip79 requested a review from jkamalu January 16, 2026 00:07
@Phlip79 Phlip79 added the Expert Review Apply this label to indicate that your PR is ready for expert review. label Jan 16, 2026
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Jan 16, 2026
…2912

Signed-off-by: oliver könig <okoenig@nvidia.com>
@asolergi-nv
Copy link
Contributor Author

/ok to test 7e05aff

ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Jan 16, 2026
…2912

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g enabled auto-merge January 16, 2026 22:56
@ko3n1g
Copy link
Contributor

ko3n1g commented Jan 16, 2026

/ok to test 937d421

@ko3n1g
Copy link
Contributor

ko3n1g commented Jan 16, 2026

/ok to test e895adc

@ko3n1g ko3n1g added this pull request to the merge queue Jan 16, 2026
Merged via the queue into NVIDIA:main with commit b305422 Jan 17, 2026
45 of 47 checks passed
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 23, 2026
…IDIA#2912)

Co-authored-by: oliver könig <okoenig@nvidia.com>
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
…IDIA#2912)

Co-authored-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review Apply this label to indicate that your PR is ready for expert review. Final Review Apply this label to indicate that your PR is ready for final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants