Skip to content

Comments

[Dev] [fix] Bug fix for fine-grained activation offloading in evaluate()#3041

Merged
yanring merged 1 commit intoNVIDIA:devfrom
lhb8125:hongbinl/fix_evaluate
Jan 22, 2026
Merged

[Dev] [fix] Bug fix for fine-grained activation offloading in evaluate()#3041
yanring merged 1 commit intoNVIDIA:devfrom
lhb8125:hongbinl/fix_evaluate

Conversation

@lhb8125
Copy link
Contributor

@lhb8125 lhb8125 commented Jan 22, 2026

What does this PR do ?

PR for main
Return None when the forward offloading chunk handlers are used up, which could occur in evaluate(), where only forward pass is executed.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@lhb8125 lhb8125 requested review from a team as code owners January 22, 2026 08:51
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@lhb8125 lhb8125 requested a review from yanring January 22, 2026 08:52
@lhb8125 lhb8125 added this to the Core 0.16 milestone Jan 22, 2026
@lhb8125 lhb8125 added the dev branch Dev branch related issues and development label Jan 22, 2026
@lhb8125 lhb8125 self-assigned this Jan 22, 2026
@lhb8125
Copy link
Contributor Author

lhb8125 commented Jan 22, 2026

/ok to test 0bcdf9c

Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
@lhb8125 lhb8125 force-pushed the hongbinl/fix_evaluate branch from 0bcdf9c to 16ca9e8 Compare January 22, 2026 10:13
@lhb8125
Copy link
Contributor Author

lhb8125 commented Jan 22, 2026

/ok to test 16ca9e8

@lhb8125 lhb8125 changed the title [Dev] [fix] Disable offloading in evaluate() [Dev] [fix] Bug fix for offloading in evaluate() Jan 22, 2026
@yanring yanring added this pull request to the merge queue Jan 22, 2026
Merged via the queue into NVIDIA:dev with commit 6807df4 Jan 22, 2026
91 of 97 checks passed
@yanring yanring changed the title [Dev] [fix] Bug fix for offloading in evaluate() [Dev] [fix] Bug fix for fine-grained activation offloading in evaluate() Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants