Skip to content

Comments

Add script for batch running CI tests across distinct nodes#3047

Merged
ko3n1g merged 2 commits intoNVIDIA:mainfrom
jon-barker:jbarker/batch_ci_tests_script
Jan 22, 2026
Merged

Add script for batch running CI tests across distinct nodes#3047
ko3n1g merged 2 commits intoNVIDIA:mainfrom
jon-barker:jbarker/batch_ci_tests_script

Conversation

@jon-barker
Copy link
Contributor

@jon-barker jon-barker commented Jan 22, 2026

What does this PR do ?

Adds a helper script that allows you to automatically roll out a generated CI functional test script across N distinct compute jobs. Depending on the cluster queue status this doesn't guarantee distinct nodes since your job.

The script autogenerates an output log dir which contains helper scripts to check if all jobs passed the test and what nodes those tests ran on.

Example usage:

Run the original moe test 10 times

./tests/functional_tests/shell_test_utils/run_batch_ci_tests.sh test_cases/moe/gpt_grpo_tp4tp2_pp1_ep4ep2_dp8_throughputtest.sh

Run a bert test 5 times

./tests/functional_tests/shell_test_utils/run_batch_ci_tests.sh test_cases/bert/bert_mcore_tp2_pp2.sh 5

Run a gpt test on a specific partition

./tests/functional_tests/shell_test_utils/run_batch_ci_tests.sh test_cases/gpt/gpt3_mcore_te_tp2_pp2.sh 10 batch_block1

List available tests

./tests/functional_tests/shell_test_utils/run_batch_ci_tests.sh --list
./tests/functional_tests/shell_test_utils/run_batch_ci_tests.sh --list gpt

Note: this script was brought to you by Claude.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@ko3n1g ko3n1g merged commit 8c768ea into NVIDIA:main Jan 22, 2026
48 of 50 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants