Skip to content

Comments

ci: Skip test_precision_aware_optimizer#3062

Merged
thomasdhc merged 1 commit intoNVIDIA:mainfrom
thomasdhc:donghyukc/disable_test_precision_aware_optimizer
Jan 24, 2026
Merged

ci: Skip test_precision_aware_optimizer#3062
thomasdhc merged 1 commit intoNVIDIA:mainfrom
thomasdhc:donghyukc/disable_test_precision_aware_optimizer

Conversation

@thomasdhc
Copy link
Contributor

What does this PR do ?

Skip test_precision_aware_optimizer inconsistent ci test runs

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
"moment_dtype",
[torch.float32, torch.float16, torch.bfloat16, torch.uint8],
)
@pytest.mark.skip(reason="inconsistent ci test runs resulting in NCCL errors")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably works fine but we also have the flaky marker. Let's just merge this to get the job done. We can check with Oliver on preferred marker in this repo next week.

@thomasdhc thomasdhc added this pull request to the merge queue Jan 23, 2026
Merged via the queue into NVIDIA:main with commit 30dea5d Jan 24, 2026
51 checks passed
@thomasdhc thomasdhc deleted the donghyukc/disable_test_precision_aware_optimizer branch January 24, 2026 00:16
FDecaYed pushed a commit to FDecaYed/Megatron-LM that referenced this pull request Jan 26, 2026
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
FDecaYed pushed a commit to FDecaYed/Megatron-LM that referenced this pull request Jan 27, 2026
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants