Skip to content

Comments

[Main] Fix EP Overlap Bugs for Full-Iter CG#3164

Merged
Wohox merged 20 commits intoNVIDIA:mainfrom
Wohox:pingtian/fix_1f1b_overlap_bug_with_full_iter_cg_main
Feb 12, 2026
Merged

[Main] Fix EP Overlap Bugs for Full-Iter CG#3164
Wohox merged 20 commits intoNVIDIA:mainfrom
Wohox:pingtian/fix_1f1b_overlap_bug_with_full_iter_cg_main

Conversation

@Wohox
Copy link
Contributor

@Wohox Wohox commented Jan 30, 2026

What does this PR do ?

Fix following bugs for full-iter cg:

  • Missing stream context for backward dw.
  • Memory leak when using HybridEP+FP8.
  • Missing record stream for HybridEP's tokens_per_expert.
  • Accidentally release the input memory of grouped gemm.
    PR for dev: [Dev] Fix EP Overlap Bugs for Full-Iter CG #3163

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 30, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Wohox Wohox requested a review from lhb8125 January 30, 2026 04:18
@Wohox Wohox marked this pull request as ready for review February 2, 2026 07:09
@Wohox Wohox requested review from a team as code owners February 2, 2026 07:09
@ko3n1g ko3n1g requested a review from a team February 2, 2026 07:09
@Wohox Wohox changed the title (draft)[Main] Fix EP Overlap Bugs for Full-Iter CG [Main] Fix EP Overlap Bugs for Full-Iter CG Feb 2, 2026
@erhoo82 erhoo82 added bug Something isn't working Expert Review Apply this label to indicate that your PR is ready for expert review. dev2main: mbridge dev to main: this PR is needed in main for mbridge labels Feb 3, 2026
@Phlip79
Copy link
Member

Phlip79 commented Feb 4, 2026

/ok to test 4260761

@Wohox Wohox force-pushed the pingtian/fix_1f1b_overlap_bug_with_full_iter_cg_main branch from 8fdbeea to a40857f Compare February 4, 2026 04:25
@Phlip79 Phlip79 added the Final Review Apply this label to indicate that your PR is ready for final review. label Feb 11, 2026
@Wohox
Copy link
Contributor Author

Wohox commented Feb 11, 2026

/ok to test 07a80b6

@Wohox
Copy link
Contributor Author

Wohox commented Feb 12, 2026

/ok to test 92824b5

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21934133498

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21934478751

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@Wohox Wohox added this pull request to the merge queue Feb 12, 2026
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21935218560

Merged via the queue into NVIDIA:main with commit dedb6dd Feb 12, 2026
46 checks passed
@Wohox Wohox deleted the pingtian/fix_1f1b_overlap_bug_with_full_iter_cg_main branch February 12, 2026 06:26
@jaredcasper jaredcasper mentioned this pull request Feb 18, 2026
6 tasks
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working complexity: medium dev2main: mbridge dev to main: this PR is needed in main for mbridge Expert Review Apply this label to indicate that your PR is ready for expert review. Final Review Apply this label to indicate that your PR is ready for final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants