Skip to content

Comments

Removing etc from main index page, shifted name of discussions#3271

Merged
Phlip79 merged 1 commit intoNVIDIA:mainfrom
megnvidia:mmiranda-remove-etc
Feb 11, 2026
Merged

Removing etc from main index page, shifted name of discussions#3271
Phlip79 merged 1 commit intoNVIDIA:mainfrom
megnvidia:mmiranda-remove-etc

Conversation

@megnvidia
Copy link
Contributor

…C topic

What does this PR do ?

removing etc from main index page, shifted name of discussions

Optional thought to move models under Resources.

It would also be cool to add a page that links to Support and/or FAQs. Do we have that info? Any community links? like to a discord or Nvidia developer portal thingie?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

…C topic

Signed-off-by: meg miranda <mmiranda@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 5, 2026 19:11
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Feb 7, 2026
@Phlip79 Phlip79 changed the title mmiranda removing etc from main index page, shifted name of discussions Removing etc from main index page, shifted name of discussions Feb 11, 2026
@Phlip79 Phlip79 added the docs-only documentation only (docs or docstrings) label Feb 11, 2026
@Phlip79
Copy link
Member

Phlip79 commented Feb 11, 2026

/ok to test ad61e71

@Phlip79 Phlip79 enabled auto-merge February 11, 2026 18:39
@ko3n1g ko3n1g added this to the Core 0.16 milestone Feb 11, 2026
@Phlip79 Phlip79 added this pull request to the merge queue Feb 11, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2026
Signed-off-by: meg miranda <mmiranda@nvidia.com>
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21918322211

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21918509410

@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Feb 11, 2026
Merged via the queue into NVIDIA:main with commit d0b768f Feb 11, 2026
32 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request docs-only documentation only (docs or docstrings)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants