Skip to content

Comments

Improved PyTorch profiler and added PyTorch execution trace#3273

Merged
shengf-nv merged 4 commits intoNVIDIA:mainfrom
shengf-nv:shengf/fix-pytorch-profiler
Feb 11, 2026
Merged

Improved PyTorch profiler and added PyTorch execution trace#3273
shengf-nv merged 4 commits intoNVIDIA:mainfrom
shengf-nv:shengf/fix-pytorch-profiler

Conversation

@shengf-nv
Copy link
Contributor

@shengf-nv shengf-nv commented Feb 5, 2026

What does this PR do ?

Improved PyTorch profiler and added PyTorch execution trace

  1. Added the following command line options to config PyTorch profile:
    pytorch_profiler_collect_shapes: bool = False
    """Collect tensor shape in pytorch profiler."""
    It is hard coded to True now.

    pytorch_profiler_collect_callstack: bool = False
    """Collect callstack in pytorch profiler."""
    It is hard coded to True now.

    pytorch_profiler_collect_chakra: bool = False
    """ Collect PyTorch execution trace"
    It is not supported now.

  2. Improved profile_ranks option, if user want to profile all ranks, user can set it to an empty list instead of putting all ranks in the list. When the number of ranks are large, the list is very long, it is not user friendly. Also most of time not profiling all ranks does NOT work since when the ranks are saving the profiling data to file, other ranks that are not profiled are waiting, it will lead to NCCL timeout, and the workload will crash.

  3. Save PyTorch profiling to directory "pytorch_profile" and save Chakra trace to directory "chakra", and the output traces are compressed also, the name convention is rank-xxx.json.gz.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 5, 2026 22:09
@shengf-nv
Copy link
Contributor Author

/ok to test 076baad

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21916908521

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21917977924

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21918509032

Merged via the queue into NVIDIA:main with commit 2807a4e Feb 11, 2026
51 checks passed
@shengf-nv shengf-nv deleted the shengf/fix-pytorch-profiler branch February 11, 2026 19:56
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants