Improved PyTorch profiler and added PyTorch execution trace#3273
Merged
shengf-nv merged 4 commits intoNVIDIA:mainfrom Feb 11, 2026
Merged
Improved PyTorch profiler and added PyTorch execution trace#3273shengf-nv merged 4 commits intoNVIDIA:mainfrom
shengf-nv merged 4 commits intoNVIDIA:mainfrom
Conversation
Contributor
Author
|
/ok to test 076baad |
maanug-nv
approved these changes
Feb 9, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21916908521 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21917977924 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21918509032 |
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Improved PyTorch profiler and added PyTorch execution trace
Added the following command line options to config PyTorch profile:
pytorch_profiler_collect_shapes: bool = False
"""Collect tensor shape in pytorch profiler."""
It is hard coded to True now.
pytorch_profiler_collect_callstack: bool = False
"""Collect callstack in pytorch profiler."""
It is hard coded to True now.
pytorch_profiler_collect_chakra: bool = False
""" Collect PyTorch execution trace"
It is not supported now.
Improved profile_ranks option, if user want to profile all ranks, user can set it to an empty list instead of putting all ranks in the list. When the number of ranks are large, the list is very long, it is not user friendly. Also most of time not profiling all ranks does NOT work since when the ranks are saving the profiling data to file, other ranks that are not profiled are waiting, it will lead to NCCL timeout, and the workload will crash.
Save PyTorch profiling to directory "pytorch_profile" and save Chakra trace to directory "chakra", and the output traces are compressed also, the name convention is rank-xxx.json.gz.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.