Skip to content

Comments

Improved parallel logging of learning rate#3319

Merged
ko3n1g merged 3 commits intoNVIDIA:mainfrom
jstjohn:update_lr_logging
Feb 12, 2026
Merged

Improved parallel logging of learning rate#3319
ko3n1g merged 3 commits intoNVIDIA:mainfrom
jstjohn:update_lr_logging

Conversation

@jstjohn
Copy link
Contributor

@jstjohn jstjohn commented Feb 9, 2026

What does this PR do ?

Rewrite of how we handle parallel logging of the learning rate. Taking advantage of some megatron functionality including making use of the learning rate stored in empty param groups (eg those that have weights on other ranks). This PR replaces #3258

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@jstjohn jstjohn requested a review from ko3n1g February 9, 2026 18:40
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 9, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jstjohn
Copy link
Contributor Author

jstjohn commented Feb 9, 2026

/ok to test fae5e57

Copy link
Contributor

@BoxiangW BoxiangW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@ko3n1g ko3n1g added Run functional tests core_r0.16.0 Cherry-pick label for core_r0.16.0 release branch Final Review Apply this label to indicate that your PR is ready for final review. labels Feb 9, 2026
@jstjohn
Copy link
Contributor Author

jstjohn commented Feb 11, 2026

/ok to test cd66f91

@ko3n1g ko3n1g enabled auto-merge February 11, 2026 00:52
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 11, 2026

validated on the gpt release run

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21927774607

@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21928298859

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@ko3n1g
Copy link
Contributor

ko3n1g commented Feb 12, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21945988636

Merged via the queue into NVIDIA:main with commit 47938af Feb 12, 2026
197 of 199 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Co-authored-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core_r0.16.0 Cherry-pick label for core_r0.16.0 release branch Final Review Apply this label to indicate that your PR is ready for final review. Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants