Skip to content

Comments

build: Bump TE on 2.12#3371

Merged
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/build/bump-te-212-2
Feb 11, 2026
Merged

build: Bump TE on 2.12#3371
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/build/bump-te-212-2

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Feb 11, 2026

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from a team February 11, 2026 18:23
@ko3n1g ko3n1g added this to the Core 0.16 milestone Feb 11, 2026
@ko3n1g ko3n1g added the core_r0.16.0 Cherry-pick label for core_r0.16.0 release branch label Feb 11, 2026
@ko3n1g ko3n1g added this pull request to the merge queue Feb 11, 2026
@ko3n1g
Copy link
Contributor Author

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21922035118

@ko3n1g
Copy link
Contributor Author

ko3n1g commented Feb 11, 2026

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21922840322

Merged via the queue into NVIDIA:main with commit 1959739 Feb 11, 2026
197 of 199 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/build/bump-te-212-2 branch February 11, 2026 22:26
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core_r0.16.0 Cherry-pick label for core_r0.16.0 release branch Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants