Add flexible virtual pipeline parallel (fVPP) to hybrid model#3377
Add flexible virtual pipeline parallel (fVPP) to hybrid model#3377duncanriach wants to merge 31 commits intoNVIDIA:mainfrom
Conversation
|
@jalbericiola @jon-barker when this is merged, we will need to update some of the configs in internal launching scripts. |
|
/ok to test 415c973 |
|
@duncanriach am I correct in understanding that the hybrid patterns that don't use the new |
Yes. Old checkpoints, including v3 checkpoints (that use |
Great - LGTM from the RL side then |
|
@jon-barker, after thinking some more about our earlier interaction, I made this change. |
What does this PR do ?
This PR introduces flexible virtual pipeline parallel (fVPP) for the hybrid model, allowing users to define explicit pipeline stage boundaries directly in the hybrid layer pattern. It also consolidates and simplifies the hybrid model configuration interface by replacing multiple arguments with a single
--hybrid-layer-patternflag and deprecating several legacy arguments. Pipelining for the hybrid model does not support MTP standalone mode, which is supported for the GPT model.It also removes the old way of enabling pipeline parallel (by just setting --pipeline-model-parallel-size > 1). Now, as well as setting that, the user has to introduce pipe ("|") symbols into the hybrid layer pattern to specify how the layers should be partitioned between pipeline stages.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.