Integrate Automated QDQ placement tool - Part 1#701
Merged
ajrasane merged 5 commits intoNVIDIA:mainfrom Feb 3, 2026
Merged
Conversation
This was referenced Dec 17, 2025
longlee0622
reviewed
Dec 17, 2025
9c53783 to
f872e70
Compare
Contributor
Author
|
Hi @gcunhase, could you help me review this PR? thanks! |
ajrasane
reviewed
Jan 5, 2026
ajrasane
reviewed
Jan 6, 2026
bbbc98b to
80792fa
Compare
Contributor
|
LGTM from my side. Will wait for @gcunhase review. |
gcunhase
reviewed
Jan 8, 2026
gcunhase
reviewed
Jan 8, 2026
gcunhase
reviewed
Jan 8, 2026
gcunhase
reviewed
Jan 8, 2026
Contributor
|
LGTM, added a few comments, thanks. |
80792fa to
66ef3ad
Compare
gcunhase
reviewed
Jan 9, 2026
gcunhase
reviewed
Jan 9, 2026
66ef3ad to
01b383a
Compare
gcunhase
reviewed
Jan 13, 2026
gcunhase
reviewed
Jan 13, 2026
4545a57 to
be965aa
Compare
ajrasane
reviewed
Jan 27, 2026
ajrasane
reviewed
Jan 27, 2026
3fc1ffa to
e07b7e4
Compare
gcunhase
reviewed
Jan 27, 2026
gcunhase
reviewed
Jan 27, 2026
ajrasane
reviewed
Jan 29, 2026
ajrasane
reviewed
Jan 29, 2026
ajrasane
reviewed
Jan 29, 2026
ajrasane
reviewed
Jan 29, 2026
ajrasane
reviewed
Jan 29, 2026
ajrasane
reviewed
Jan 29, 2026
ajrasane
reviewed
Jan 29, 2026
64817f4 to
ef95c8d
Compare
auto-merge was automatically disabled
January 30, 2026 02:05
Head branch was pushed to by a user without write access
ef95c8d to
79ee540
Compare
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
79ee540 to
09a91a8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 73.82% 74.16% +0.33%
==========================================
Files 193 195 +2
Lines 19745 20111 +366
==========================================
+ Hits 14577 14915 +338
- Misses 5168 5196 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/ok to test 09a91a8 |
danielkorzekwa
pushed a commit
that referenced
this pull request
Feb 17, 2026
## What does this PR do? **Type of change:** new feature **Overview:** This PR integrates an automatical QDQ placment tool into ModelOpt. This PR is the 1/4 parts of the change, it contains the following changes: 1. Defines common types: Region, RegionType, Error types 2. Defines InsertionPoints (the logical localtion to place QDQ pairs), InsertionScheme (a set of insertion points) 3. Unit tests for new types Part 1: #701 Part 2: #702 Part 3: #703 Part 4: #704 ## Usage ```python # Region type usage: region = Region(region_id=1, level=0, region_type=RegionType.LEAF) assert region.get_id() == 1 assert region.get_level() == 0 region.add_node(1) # 1 is the index of ONNX graph node ... point = NodeInputInsertionPoint(node_index=0, input_index=2) assert point.node_index == 0 # relative node index in region assert point.input_index == 2 # relative input tensor index in specific node resolved = point.resolve(region, graph) ... ``` ## Testing Implement unit tests, all tests could get passed. ## Before your PR is "*Ready for review*" <!-- If you haven't finished some of the above items you can still open `Draft` PR. --> - **Make sure you read and follow [Contributor guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md)** and your commits are signed. - **Is this change backward compatible?**: Yes - **Did you write any new necessary tests?**: Yes - **Did you add or update any necessary documentation?**: No, document change will be included in part 4. - **Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?**: No, this could be done when all parts of the change are merged. ## Additional Information <!-- E.g. related issue. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added foundational autotuner infrastructure for quantization optimization, including region hierarchies and insertion scheme management. * Introduced insertion point system for managing quantize/dequantize operation placement across ONNX graph regions. * Added utility functions for tensor consumer mapping and boolean operation identification. * **Tests** * Added comprehensive test coverage for autotuner components, insertion points, and region management. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Will Guo <willg@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: new feature
Overview: This PR integrates an automatical QDQ placment tool into ModelOpt.
This PR is the 1/4 parts of the change, it contains the following changes:
Part 1: #701
Part 2: #702
Part 3: #703
Part 4: #704
Usage
Testing
Implement unit tests, all tests could get passed.
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.