CometoidWMTQualityEstimation processor implementation#151
Merged
ssh-meister merged 4 commits intomainfrom Aug 5, 2025
Merged
Conversation
Signed-off-by: Sasha Meister <ameister@nvidia.com>
lilithgrigoryan
requested changes
Aug 4, 2025
Collaborator
lilithgrigoryan
left a comment
lilithgrigoryan
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please see minor comments:)
| self.model = None | ||
|
|
||
| def load_model(self): | ||
| from pymarian import Evaluator |
Collaborator
There was a problem hiding this comment.
Let’s wrap this in a try/except block. Attempt to import Evaluator, and if the import fails, log a message indicating that pymarian needs to be installed.
|
|
||
| self.model = Evaluator(marian_args) | ||
|
|
||
| def process_dataset_entry(self): |
Collaborator
There was a problem hiding this comment.
Is there a reason to inherit from BaseParallel processor if we do not use process_dataset_entry
tests/test_cometoid_qe.py
Outdated
| mock_processor.finalize = MagicMock() | ||
| mock_processor.number_of_entries = 0 | ||
|
|
||
| # 👇 Patch load_model to avoid real downloading |
Collaborator
There was a problem hiding this comment.
I love the emoji 😄 But sadly, our codebase is an emoji-free zone 🚫. Mind removing it?
Signed-off-by: root <root@cpu-00064.cm.cluster>
lilithgrigoryan
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A processor for estimating translation quality using pretrained COMET-like models based on MarianNMT and the pymarian Evaluator