Conversation
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
for more information, see https://pre-commit.ci Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
… into jp_itn_20231212 Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
for more information, see https://pre-commit.ci
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Collaborator
|
@BuyuanCui should we close this PR in favor of #141 ? |
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Merge to main for Japanese support on cardinal, ordinal, time, date, fraction, decimal support
Add a one line overview of what this PR aims to accomplish.
This is a PR for Japanese ITN support.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.