Skip to content

es and es_en changes for unified models#143

Merged
tbartley94 merged 24 commits intomainfrom
en_es_unified_changes
Aug 14, 2024
Merged

es and es_en changes for unified models#143
tbartley94 merged 24 commits intomainfrom
en_es_unified_changes

Conversation

@mgrafu
Copy link
Collaborator

@mgrafu mgrafu commented Feb 28, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

mgrafu and others added 4 commits February 28, 2024 10:26
@mgrafu
enable capitalized itn for es
f40a62d 
Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
@mgrafu
enable capitalized itn for es_en
5fcafae 
Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
@mgrafu
Merge branch 'main' into en_es_unified_changes
e473184 
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
64fd6c7 
for more information, see https://pre-commit.ci
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 28, 2024
View reviewed changes
mgrafu and others added 3 commits February 29, 2024 07:29
@mgrafu
style changes
e36c813 
Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
@mgrafu
style changes
5c701fe 
Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
16eeecc 
for more information, see https://pre-commit.ci
@github-actions
Copy link

github-actions bot commented Mar 15, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 15, 2024
@mgrafu mgrafu removed the Stale label Mar 15, 2024
@mgrafu
fix imports
1ea5fd5 
Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 10, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 10, 2024
@mgrafu mgrafu removed the Stale label Apr 10, 2024
@ekmb
Copy link
Collaborator

ekmb commented Apr 16, 2024

@mgrafu is this PR WIP?

@mgrafu
Copy link
Collaborator Author

mgrafu commented Apr 23, 2024

@ekmb yes! the majority of the changes are done, but I'm reviewing bugs before final review

@github-actions
Copy link

github-actions bot commented May 8, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 8, 2024
@mgrafu mgrafu removed the Stale label May 8, 2024
@github-actions
Copy link

github-actions bot commented May 23, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 23, 2024
@mgrafu mgrafu removed the Stale label May 29, 2024
@github-actions
Copy link

github-actions bot commented Jun 13, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 13, 2024
@mgrafu mgrafu removed the Stale label Jun 14, 2024
mgrafu and others added 4 commits June 25, 2024 14:51
@mgrafu
mod eval scripts
fa0a970 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f9f6945 
for more information, see https://pre-commit.ci
@mgrafu
update whitelist
a85e039 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
update currencies for es itn
2dbaf56 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
mgrafu and others added 3 commits July 3, 2024 13:04
@mgrafu
bugfix for es time grammar
e95cb4f 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
update cache for es
a00b6a8 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
Merge branch 'main' into en_es_unified_changes
6f0e5da 
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
@mgrafu mgrafu requested a review from tbartley94 July 3, 2024 23:21
tbartley94
tbartley94 requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@tbartley94 tbartley94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments and requested changes. There's a few mispellings, questions about edge cases, and request for variable renaming.

I trust the test cases are boilerplate, didn't go into much detail there.

mgrafu and others added 8 commits July 23, 2024 08:24
@mgrafu
ordinal tagger fix
52b1493 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
telephone tagger fix
d67fff6 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
time tagger fix
f627075 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
time verbalizer fix
b7a09c8 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
update cache
e232c43 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu
Merge branch 'main' into en_es_unified_changes
90980c4 
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
86ffe6c 
for more information, see https://pre-commit.ci
@mgrafu
Merge branch 'main' into en_es_unified_changes
5d9468c 
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 13, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 13, 2024
@mgrafu mgrafu removed the Stale label Aug 13, 2024
tbartley94
tbartley94 reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@tbartley94 tbartley94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on merge conflicts to be resolved then will approve

@mgrafu
Merge branch 'main' into en_es_unified_changes
134ffee 
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
@mgrafu mgrafu requested a review from tbartley94 August 14, 2024 18:43
tbartley94
tbartley94 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@tbartley94 tbartley94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbartley94 tbartley94 merged commit 5e238fa into main Aug 14, 2024
tbartley94 added a commit that referenced this pull request Aug 14, 2024
@tbartley94
Revert "es and es_en changes for unified models (#143)"
17ba9db 
This reverts commit 5e238fa.
@ekmb ekmb deleted the en_es_unified_changes branch August 15, 2024 21:42
BuyuanCui pushed a commit that referenced this pull request Aug 20, 2024
@mgrafu @pre-commit-ci @BuyuanCui
es and es_en changes for unified models (#143)
5246add 
* enable capitalized itn for es

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* enable capitalized itn for es_en

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* style changes

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* mod eval scripts

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update whitelist

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update currencies for es itn

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* bugfix for es time grammar

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache for es

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* ordinal tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* telephone tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time verbalizer fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Sep 19, 2024
@mgrafu @pre-commit-ci @BuyuanCui
es and es_en changes for unified models (#143)
a8ca196 
* enable capitalized itn for es

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* enable capitalized itn for es_en

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* style changes

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* mod eval scripts

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update whitelist

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update currencies for es itn

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* bugfix for es time grammar

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache for es

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* ordinal tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* telephone tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time verbalizer fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Sep 26, 2024
@mgrafu @pre-commit-ci @BuyuanCui
es and es_en changes for unified models (#143)
60addc6 
* enable capitalized itn for es

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* enable capitalized itn for es_en

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* style changes

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* mod eval scripts

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update whitelist

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update currencies for es itn

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* bugfix for es time grammar

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache for es

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* ordinal tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* telephone tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time verbalizer fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Sep 26, 2024
@mgrafu @pre-commit-ci @BuyuanCui
es and es_en changes for unified models (#143)
9a8acb8 
* enable capitalized itn for es

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* enable capitalized itn for es_en

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* style changes

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* mod eval scripts

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update whitelist

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update currencies for es itn

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* bugfix for es time grammar

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache for es

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* ordinal tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* telephone tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time verbalizer fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Oct 16, 2024
@mgrafu @pre-commit-ci @BuyuanCui
es and es_en changes for unified models (#143)
75d8548 
* enable capitalized itn for es

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* enable capitalized itn for es_en

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* style changes

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* mod eval scripts

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update whitelist

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update currencies for es itn

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* bugfix for es time grammar

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache for es

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* ordinal tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* telephone tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time verbalizer fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
ngachchi pushed a commit to ngachchi/NeMo-text-processing that referenced this pull request Jun 23, 2025
@mgrafu @pre-commit-ci @ngachchi
es and es_en changes for unified models (NVIDIA#143)
d43ce04 
* enable capitalized itn for es

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* enable capitalized itn for es_en

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* style changes

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* mod eval scripts

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update whitelist

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update currencies for es itn

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* bugfix for es time grammar

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache for es

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* ordinal tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* telephone tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time verbalizer fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
FredHaa pushed a commit to FredHaa/NeMo-text-processing that referenced this pull request Aug 15, 2025
@mgrafu @pre-commit-ci
es and es_en changes for unified models (NVIDIA#143)
8555513 
* enable capitalized itn for es

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* enable capitalized itn for es_en

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* style changes

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>

* mod eval scripts

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update whitelist

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update currencies for es itn

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* bugfix for es time grammar

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache for es

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* ordinal tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* telephone tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time tagger fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* time verbalizer fix

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update cache

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <mgrafu@gmail.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbartley94 tbartley94 tbartley94 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrafu @ekmb @tbartley94