Merged
Conversation
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
for more information, see https://pre-commit.ci
tbartley94
reviewed
May 15, 2024
nemo_text_processing/text_normalization/en/taggers/electronic.py
Outdated
Show resolved
Hide resolved
tbartley94
previously approved these changes
May 15, 2024
Member
|
Commenting for clarity on review: cardinals and credit cards are going to overlap here. We can permit a higher weight for full credit card strings |
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Member
|
Plurals for time was altered. |
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Jul 12, 2024
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Jul 25, 2024
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Aug 20, 2024
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 19, 2024
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 26, 2024
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 26, 2024
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Oct 16, 2024
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
ngachchi
pushed a commit
to ngachchi/NeMo-text-processing
that referenced
this pull request
Jun 23, 2025
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
FredHaa
pushed a commit
to FredHaa/NeMo-text-processing
that referenced
this pull request
Aug 15, 2025
* update tts whitelist Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * enable normalization of emphasized input Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add whitelist terms Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * add test for emphasis Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * read card numbers as digits Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make ccs deterministic Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh tests bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix bug with time Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * update jenkins Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> * fix sh time bug Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> --------- Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com> Signed-off-by: Mariana <47233618+mgrafu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
changes to en tn for tts
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.