Skip to content

preparing release, updating change log#168

Merged
ekmb merged 3 commits intoNVIDIA:mainfrom
tbartley94:r1.0.0
May 3, 2024
Merged

preparing release, updating change log#168
ekmb merged 3 commits intoNVIDIA:mainfrom
tbartley94:r1.0.0

Conversation

@tbartley94
Copy link
Member

What does this PR do ?

r1.0.0 Release

Before your PR is "Ready for review"

Pre checks:

  • [y ] Have you signed your commits? Use git commit -s to sign.
  • [ y] Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • [n ] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • [ y] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • [y ] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • [ y] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • [n ] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • [ n] Remove import guards (try import: ... except: ...) if not already done.
  • [n ] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • [y] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • [y] Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

tbartley94 added 3 commits May 3, 2024 14:12
Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Travis Bartley <tbartley@nvidia.com>
@ekmb ekmb merged commit 844fd95 into NVIDIA:main May 3, 2024
BuyuanCui pushed a commit that referenced this pull request Jul 12, 2024
* preparing release, updating change log

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* adding changelog

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* updating pre release

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

---------

Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Aug 20, 2024
* preparing release, updating change log

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* adding changelog

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* updating pre release

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

---------

Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Sep 19, 2024
* preparing release, updating change log

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* adding changelog

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* updating pre release

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

---------

Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Sep 26, 2024
* preparing release, updating change log

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* adding changelog

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* updating pre release

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

---------

Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit that referenced this pull request Oct 16, 2024
* preparing release, updating change log

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* adding changelog

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* updating pre release

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

---------

Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
ngachchi pushed a commit to ngachchi/NeMo-text-processing that referenced this pull request Jun 23, 2025
* preparing release, updating change log

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* adding changelog

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* updating pre release

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

---------

Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
FredHaa pushed a commit to FredHaa/NeMo-text-processing that referenced this pull request Aug 15, 2025
* preparing release, updating change log

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* adding changelog

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

* updating pre release

Signed-off-by: Travis Bartley <tbartley@nvidia.com>

---------

Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants