Merged
Conversation
Signed-off-by: Simon Zuberek <szuberek@nvidia.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
pushed a commit
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
ngachchi
pushed a commit
to ngachchi/NeMo-text-processing
that referenced
this pull request
Jun 23, 2025
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
FredHaa
pushed a commit
to FredHaa/NeMo-text-processing
that referenced
this pull request
Aug 15, 2025
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The
%sign is now accepted by Italian TN (see this issue).The implementation passes all
pyTests but fails a handful ofSparrowhawktests. Since the current fix adds a single mapping, tonemo_text_processing/text_normalization/it/data/measure/measurements.tsv, it is unlikely to be related toSparrowhawkfailures.Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.